Support multiple roots #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medied
reviewed
Dec 6, 2023
README.md
Outdated
Comment on lines
72
to
73
| root | string|Element|Element[] | `document` | Where to look for elements that should have the popup | ||
| selector. Can be a selector to locate the root, a DOM Element, or an array of Elements | string | `'[data-wikipedia-preview]'` | How nodes that should have the popup are identified |
There was a problem hiding this comment.
Looking at the README.md preview (below), I think the table is a bit messed up? You mean that the type of root can be either string | Element | Element[]? But the | messes up the table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T348261